[webkit-reviews] review granted: [Bug 213438] Code cleanup in WebAccessibilityObjectWrapper updateObjectBackingStore and position. : [Attachment 402403] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 213438: Code cleanup in WebAccessibilityObjectWrapper
updateObjectBackingStore and position.
https://bugs.webkit.org/show_bug.cgi?id=213438

Attachment 402403: Patch

https://bugs.webkit.org/attachment.cgi?id=402403&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 402403
  --> https://bugs.webkit.org/attachment.cgi?id=402403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402403&action=review

> Source/WebCore/ChangeLog:10
> +	   Reviewed by NOBODY (OOPS!).
> +
> +
> +
> +	   * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

Some extra blank lines here.

> Source/WebCore/ChangeLog:16
> +	   Check for isIsolatedTreeEnabled, not just for the request thread.

This comment makes it sound like we want to check both, but the code seems to
no longer check the thread.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:346
> +    auto* backingObject = self.axBackingObject;

I would have just used "auto" rather than "auto*", but many others prefer it
this way.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1976
>	   return [NSValue
valueWithPoint:(NSPoint)self.axBackingObject->relativeFrame().location()];

Surprised we need the cast to NSPoint here.