[webkit-reviews] review granted: [Bug 213370] Failure the case of "null type Blob slice" in wpt/FileAPI/blob/Blob-slice.html : [Attachment 402426] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 213370: Failure the case of "null type Blob slice" in
wpt/FileAPI/blob/Blob-slice.html
https://bugs.webkit.org/show_bug.cgi?id=213370

Attachment 402426: Patch

https://bugs.webkit.org/attachment.cgi?id=402426&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 402426
  --> https://bugs.webkit.org/attachment.cgi?id=402426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402426&action=review

> Source/WebCore/fileapi/Blob.idl:45
> +    Blob slice(optional long long start = 0,
> +		  optional long long end = 0x7FFFFFFFFFFFFFFF,
> +		  optional DOMString contentType = "");

My preferences would be to not format like this -- in WebKit we normally don’t
intent to line up with open parenthesis and it seems we could leave this as a
long line. That would have the advantage of having an easy to read diff. But
maybe this is just pasted from the specification text?