[webkit-reviews] review granted: [Bug 213426] WebKit fails to leave audio routing arbitration during navigation, closing. : [Attachment 402378] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 213426: WebKit fails to leave audio routing arbitration during navigation,
closing.
https://bugs.webkit.org/show_bug.cgi?id=213426

Attachment 402378: Patch

https://bugs.webkit.org/attachment.cgi?id=402378&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 402378
  --> https://bugs.webkit.org/attachment.cgi?id=402378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402378&action=review

Is it worth adding a test that deletes the <video> element?

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:245
> +    case
WebKit::AudioSessionRoutingArbitratorProxy::ArbitrationStatus::None:return
WKWebViewAudioRoutingArbitrationStatusNone;

Nit: missing a space before "return"