[webkit-reviews] review denied: [Bug 213393] Added getFloatTimeDomainData method to AnalyserNode : [Attachment 402335] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213393: Added getFloatTimeDomainData method to AnalyserNode
https://bugs.webkit.org/show_bug.cgi?id=213393

Attachment 402335: Patch

https://bugs.webkit.org/attachment.cgi?id=402335&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 402335
  --> https://bugs.webkit.org/attachment.cgi?id=402335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402335&action=review

> Source/WebCore/Modules/webaudio/AnalyserNode.h:58
> +    void getFloatTimeDomainData(const RefPtr<JSC::Float32Array>& array) {
m_analyser.getFloatTimeDomainData(array.get()); }

const Ref<JSC::Float32Array>&

Same for others.

> Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-107
> -	   return;    

Please configure your IDE to stop doing these things. We try to avoid unrelated
changes in patches as much as possible.

> Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-207
> -    if (!destinationArray)

Since destinationArray cannot take null anymore, the parameter should be of
type:
Float32Array& destinationArray

This means you'll need to update AnalyzerNode::getFloatFrequencyData() to take
in a Ref<> instead of a RefPtr<>.

> Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-232
> -    if (!destinationArray)

ditto

> Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-269
> -    if (!destinationArray)

ditto.