[webkit-reviews] review granted: [Bug 213419] [JSC] Attempt to reduce timeout failures on Apple Watch Series 3 : [Attachment 402350] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213419: [JSC] Attempt to reduce timeout failures on Apple Watch Series 3
https://bugs.webkit.org/show_bug.cgi?id=213419

Attachment 402350: Patch

https://bugs.webkit.org/attachment.cgi?id=402350&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402350
  --> https://bugs.webkit.org/attachment.cgi?id=402350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402350&action=review

r=me

> JSTests/stress/memcpy-typed-loops.js:31
> -for (let i=0; i<10000000; ++i) noLoop(arr1, arr2)
> -for (let i=0; i<10000000; ++i) invalidStart(arr1, arr2)
> +for (let i=0; i<100000; ++i) noLoop(arr1, arr2)
> +for (let i=0; i<100000; ++i) invalidStart(arr1, arr2)

Instead of this, can we just do a $vm.useJIT() test and set the iteration count
accordingly?  Since watch doesn't use JIT, we can go with an even smaller count
than this.  Looks like there isn't a $vm.useJIT() but you can add one.

> JSTests/stress/set-iteration-oas.js:20
> +for (var i = 0; i < 1e4; ++i)

Ditto.