[webkit-reviews] review granted: [Bug 213410] [JSC] Check Gigacage usage before launching VM : [Attachment 402338] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 19 16:23:30 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213410: [JSC] Check Gigacage usage before launching VM
https://bugs.webkit.org/show_bug.cgi?id=213410

Attachment 402338: Patch

https://bugs.webkit.org/attachment.cgi?id=402338&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402338
  --> https://bugs.webkit.org/attachment.cgi?id=402338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402338&action=review

r=me

> Source/WTF/wtf/Gigacage.h:74
> +ALWAYS_INLINE size_t size(Kind) { return 0; }
> +ALWAYS_INLINE size_t slidedSize(Kind) { return 0; }

Per our offline conversation, let's rename size() to maxSize() and slidedSize()
to size().


More information about the webkit-reviews mailing list