[webkit-reviews] review granted: [Bug 213408] [AutoSizing] Resolve viewport units against the preferred content size : [Attachment 402333] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted zalan <zalan at apple.com>'s request
for review:
Bug 213408: [AutoSizing] Resolve viewport units against the preferred content
size
https://bugs.webkit.org/show_bug.cgi?id=213408

Attachment 402333: Patch

https://bugs.webkit.org/attachment.cgi?id=402333&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 402333
  --> https://bugs.webkit.org/attachment.cgi?id=402333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402333&action=review

> Source/WebCore/ChangeLog:19
> +	   and resolved the values against the horiztonal constraint).

horiztonal

> Source/WebCore/testing/Internals.cpp:3716
> +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int
height)

We already have tests. Maybe no internals method because they’re all API tests?
OK