[webkit-reviews] review granted: [Bug 209518] [WebGL2] Uniform Buffer Objects : [Attachment 402257] fix readBuffer test

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 209518: [WebGL2] Uniform Buffer Objects
https://bugs.webkit.org/show_bug.cgi?id=209518

Attachment 402257: fix readBuffer test

https://bugs.webkit.org/attachment.cgi?id=402257&action=review




--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 402257
  --> https://bugs.webkit.org/attachment.cgi?id=402257
fix readBuffer test

View in context: https://bugs.webkit.org/attachment.cgi?id=402257&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.h:288
> +    bool setIndexedBufferBinding(const char *functionName, GCGLenum target,
GCGLuint index, WebGLBuffer*);

Nit: should be "char*" not "char *", but I don't think it's worth another patch
here. We'll fix it up later.

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:1940
> +    RELEASE_LOG(WebGL, "Use getActiveUniformBlockivRobustANGLE instead.");

In case someone gets here, we should probably tell them where they are. e.g.
"GraphicsContextGLOpenGL::getActiveUniformBlockiv should be replaced with
getActiveUniformBlockivRobustANGLE". Again, follow-up patch is fine.