[webkit-reviews] review denied: [Bug 213382] [ews] commit-queue should comment on bug if it fails to get contributors information : [Attachment 402291] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 213382: [ews] commit-queue should comment on bug if it fails to get
contributors information
https://bugs.webkit.org/show_bug.cgi?id=213382

Attachment 402291: Patch

https://bugs.webkit.org/attachment.cgi?id=402291&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 402291
  --> https://bugs.webkit.org/attachment.cgi?id=402291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402291&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:758
> +	       self.setProperty('bugzilla_comment_text', 'commit-queue failed
to get contributors information, please cq+ patch again.')

It is very useful to have specific guidance about what the person needs to do.
This one doesn't sound right to me - if the action were to simply mark as cq+
again, we wouldn't need to mark as cq-. Also, this information is noise to
everyone except for the person who has set cq+ originally.

So I think that two things need to change:

1. Make the guidance accurate (the whole reason to do this is to have people
reach out to admins, so we should advise on how to do this).

2. Make it private (e-mail, and don't change cq+ to cq-).

Looking at these together, I'm beginning to think that the right action is to
notify admins directly, not to ask contributors to do it.