[webkit-reviews] review granted: [Bug 213369] Add logging to RealtimeIncomingVideoSource to check for frame rate stability : [Attachment 402273] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 19 09:05:08 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted review:
Bug 213369: Add logging to RealtimeIncomingVideoSource to check for frame rate
stability
https://bugs.webkit.org/show_bug.cgi?id=213369
Attachment 402273: Patch
https://bugs.webkit.org/attachment.cgi?id=402273&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 402273
--> https://bugs.webkit.org/attachment.cgi?id=402273
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=402273&action=review
> Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp:120
> + callOnMainThread([identifier = LOGIDENTIFIER, this, protectedThis =
makeRef(*this), frameTime, lastFrameTime, observedFrameRate =
m_observedFrameRate] {
Nit: extra space before "lastFrameTime"
More information about the webkit-reviews
mailing list