[webkit-reviews] review granted: [Bug 183611] [GTK] Layout test media/context-menu-actions.html is failing : [Attachment 402211] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 19 08:49:03 PDT 2020
Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 183611: [GTK] Layout test media/context-menu-actions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=183611
Attachment 402211: Patch
https://bugs.webkit.org/attachment.cgi?id=402211&action=review
--- Comment #15 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 402211
--> https://bugs.webkit.org/attachment.cgi?id=402211
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=402211&action=review
r+ but you need to fix the changelog.
Then I have a couple of questions. First is if this patch breaks any other
tests and need a a rebase line. The seconds would be why is the test still
marked as crash.
> LayoutTests/ChangeLog:19
> + would be lost) in case we wait forever for the comparison to
evaluato to the expected value.
evaluate
More information about the webkit-reviews
mailing list