[webkit-reviews] review granted: [Bug 213357] [iOS, macOS] Allow access to the container manager to support Mail InjectedBundle : [Attachment 402242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 16:13:56 PDT 2020


Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 213357: [iOS, macOS] Allow access to the container manager to support Mail
InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=213357

Attachment 402242: Patch

https://bugs.webkit.org/attachment.cgi?id=402242&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 402242
  --> https://bugs.webkit.org/attachment.cgi?id=402242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402242&action=review

Is there any more scalable way to do this? Seems unfortunate to hardcode a
client app bundle ID again.

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:299
> +#else

How about this instead?

#elif PLATFORM(IOS)
    return WebCore::IOSApplication::isMobileMail()
#else
    return false;
#endif


More information about the webkit-reviews mailing list