[webkit-reviews] review denied: [Bug 212009] [ews] Add build bots for JSC MIPS and ARMv7 archirectures : [Attachment 402221] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has denied Diego Pino <dpino at igalia.com>'s
request for review:
Bug 212009: [ews] Add build bots for JSC MIPS and ARMv7 archirectures
https://bugs.webkit.org/show_bug.cgi?id=212009

Attachment 402221: Patch

https://bugs.webkit.org/attachment.cgi?id=402221&action=review




--- Comment #9 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 402221
  --> https://bugs.webkit.org/attachment.cgi?id=402221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402221&action=review

r- due to services ews being red.

> Tools/BuildSlaveSupport/ews-build/config.json:17
> +	 "name": "igalia-jsc32-mipsel-ews-03",

Let's add it in a separate patch and land it first (to ensure that the bot is
working fine without any configuration isssues).

> Tools/BuildSlaveSupport/ews-build/config.json:491
> +	 "shortname": "jsc-mips-t",

This name might be confusing for people. probably "jsc-mips-tests" is fine.

> Tools/BuildSlaveSupport/ews-build/config.json:513
> +	 "shortname": "jsc-armv7-t",

Ditto. This name might be confusing for people. probably "jsc-armv7-tests" is
fine.