[webkit-reviews] review granted: [Bug 213346] Workaround for UIKit layout bug in time picker. : [Attachment 402222] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 18 12:06:08 PDT 2020
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 213346: Workaround for UIKit layout bug in time picker.
https://bugs.webkit.org/show_bug.cgi?id=213346
Attachment 402222: Patch
https://bugs.webkit.org/attachment.cgi?id=402222&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 402222
--> https://bugs.webkit.org/attachment.cgi?id=402222
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=402222&action=review
> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:82
> + // FIXME: Workaround, should be able to be readresses after
<rdar://problem/64143534>
"readdresses" -> readdressed?
> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88
> + view.layoutMargins = (UIEdgeInsets) {16, 16, 16, 16};
We usually use UIEdgeInsetsMake
More information about the webkit-reviews
mailing list