[webkit-reviews] review denied: [Bug 213174] [GTK] MiniBrowser: can skip sandboxing without verbose warning : [Attachment 402204] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 213174: [GTK] MiniBrowser: can skip sandboxing without verbose warning
https://bugs.webkit.org/show_bug.cgi?id=213174

Attachment 402204: Patch

https://bugs.webkit.org/attachment.cgi?id=402204&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 402204
  --> https://bugs.webkit.org/attachment.cgi?id=402204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402204&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:684
> +    const char* appID = g_application_get_application_id(app);
> +    g_key_file_set_string(keyFile.get(), "Application", "name", appID ?
appID : g_get_prgname());

This won't work (and can't be made to work)... look three lines up. :P