[webkit-reviews] review granted: [Bug 213071] Replace JSC::FreeList linked list with a Bitmap. : [Attachment 402164] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 213071: Replace JSC::FreeList linked list with a Bitmap.
https://bugs.webkit.org/show_bug.cgi?id=213071

Attachment 402164: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=402164&action=review




--- Comment #7 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 402164
  --> https://bugs.webkit.org/attachment.cgi?id=402164
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=402164&action=review

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:341
> +	   freeAtoms ^= cellLocations;

You could probably make this faster if it was one loop that did the whole
thing. If I’m understanding right we will have a loop here for the ^= and loops
above for other parts of the freeAtoms computation.