[webkit-reviews] review granted: [Bug 213214] Stop calling userPreferredLanguages() in the UIProcess : [Attachment 401959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 16 08:26:19 PDT 2020


Per Arne Vollan <pvollan at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 213214: Stop calling userPreferredLanguages() in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=213214

Attachment 401959: Patch

https://bugs.webkit.org/attachment.cgi?id=401959&action=review




--- Comment #15 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 401959
  --> https://bugs.webkit.org/attachment.cgi?id=401959
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401959&action=review

R=me. After this patch, can the language related code in XPCServiceMain.mm be
removed?

> Source/WebKit/UIProcess/WebProcessPool.cpp:1085
> +    userPreferredLanguages();

Is this call needed?


More information about the webkit-reviews mailing list