[webkit-reviews] review granted: [Bug 213171] [WPT] infrastructure/assumptions/html-elements.html fails due to changes in style when all: initial is used : [Attachment 401966] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 213171: [WPT] infrastructure/assumptions/html-elements.html fails due to
changes in style when all: initial is used
https://bugs.webkit.org/show_bug.cgi?id=213171

Attachment 401966: Patch

https://bugs.webkit.org/attachment.cgi?id=401966&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 401966
  --> https://bugs.webkit.org/attachment.cgi?id=401966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401966&action=review

> Source/WebCore/css/CSSProperties.json:3734
> +		   "initial": "initialStrokeColor",

I think calling RenderStyle::initialFoo is the default so just not specifying
anything here should work too.

> Source/WebCore/style/StyleBuilderCustom.h:543
> -	       image.setFill(false);
> +	       image.setFill(type == BorderImage ? false : true);

type != BorderImage