[webkit-reviews] review canceled: [Bug 213224] REGRESSION (r262994): Web inspector is killed when context-clicking anywhere : [Attachment 401979] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 15 21:52:59 PDT 2020
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 213224: REGRESSION (r262994): Web inspector is killed when context-clicking
anywhere
https://bugs.webkit.org/show_bug.cgi?id=213224
Attachment 401979: Patch v2
https://bugs.webkit.org/attachment.cgi?id=401979&action=review
--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 401979
--> https://bugs.webkit.org/attachment.cgi?id=401979
Patch v2
View in context: https://bugs.webkit.org/attachment.cgi?id=401979&action=review
> Source/WebCore/platform/ContextMenuItem.cpp:245
> + case ContextMenuAction::ContextMenuItemBaseCustomTag ...
ContextMenuAction::ContextMenuItemLastCustomTag:
LOL...of course this won't work on MSVC++ since it's a gcc extension:
C:\Buildbot\WinCairo-EWS\build\Source\WebCore\platform/ContextMenuItem.cpp(245)
: error C2143: syntax error: missing ':' before '...'
C:\Buildbot\WinCairo-EWS\build\Source\WebCore\platform/ContextMenuItem.cpp(245)
: error C2059: syntax error: '...'
More information about the webkit-reviews
mailing list