[webkit-reviews] review granted: [Bug 213067] Occasional crashes when running nested runloops while using UIWebView : [Attachment 401965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 18:55:48 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 213067: Occasional crashes when running nested runloops while using
UIWebView
https://bugs.webkit.org/show_bug.cgi?id=213067

Attachment 401965: Patch

https://bugs.webkit.org/attachment.cgi?id=401965&action=review




--- Comment #17 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 401965
  --> https://bugs.webkit.org/attachment.cgi?id=401965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401965&action=review

r=me

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:667
> +    RetainPtr<CFRunLoopObserverRef> mainRunLoopExitObserver =
adoptCF(CFRunLoopObserverCreate(nullptr, kCFRunLoopExit, YES, 3000002,
MainRunLoopExit, nullptr));

Did we promise we’d give this a name?


More information about the webkit-reviews mailing list