[webkit-reviews] review granted: [Bug 213106] Bytecode liveness should be aware of checkpoints : [Attachment 401931] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 213106: Bytecode liveness should be aware of checkpoints
https://bugs.webkit.org/show_bug.cgi?id=213106

Attachment 401931: Patch

https://bugs.webkit.org/attachment.cgi?id=401931&action=review




--- Comment #13 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 401931
  --> https://bugs.webkit.org/attachment.cgi?id=401931
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401931&action=review

r=me.

> Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:184
> +#ifndef NDEBUG

Are you sure you need the ifndef? Also, if so, can this be gated on
ASSERT_ENABLED?