[webkit-reviews] review granted: [Bug 213211] REGRESSION (r263045): TestWTF.Signals.SignalsWorkOnExit crashing : [Attachment 401934] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 213211: REGRESSION (r263045): TestWTF.Signals.SignalsWorkOnExit crashing
https://bugs.webkit.org/show_bug.cgi?id=213211

Attachment 401934: Patch

https://bugs.webkit.org/attachment.cgi?id=401934&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 401934
  --> https://bugs.webkit.org/attachment.cgi?id=401934
Patch

r+ to unbreak the API test using Signal::Usr.  However, but looks like the only
place where we add a signal handler for Signal::Usr is the API tests.  Can we
just make the test use a different signal and get rid of Signal::Usr
altogether.  Let's do that in a separate bug though.