[webkit-reviews] review granted: [Bug 213204] Consistently use WTF_ATTRIBUTE_PRINTF in Assertions.[cpp, h] : [Attachment 401919] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 15 12:31:08 PDT 2020
Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 213204: Consistently use WTF_ATTRIBUTE_PRINTF in Assertions.[cpp,h]
https://bugs.webkit.org/show_bug.cgi?id=213204
Attachment 401919: Patch
https://bugs.webkit.org/attachment.cgi?id=401919&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 401919
--> https://bugs.webkit.org/attachment.cgi?id=401919
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401919&action=review
I didn’t set the commit queue flag yet because I’d like EWS to finish first.
> Source/WTF/wtf/Assertions.cpp:175
> ALLOW_NONLITERAL_FORMAT_BEGIN
I wonder if we still need this?
More information about the webkit-reviews
mailing list