[webkit-reviews] review granted: [Bug 212856] Text form controls can scroll by 1px when value is the same length as size. No scrolling should happen. : [Attachment 401793] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Megan Gardner <megan_gardner at apple.com>'s
request for review:
Bug 212856: Text form controls can scroll by 1px when value is the same length
as size. No scrolling should happen.
https://bugs.webkit.org/show_bug.cgi?id=212856

Attachment 401793: Patch

https://bugs.webkit.org/attachment.cgi?id=401793&action=review




--- Comment #18 from zalan <zalan at apple.com> ---
Comment on attachment 401793
  --> https://bugs.webkit.org/attachment.cgi?id=401793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401793&action=review

> Source/WebCore/rendering/RenderBlockFlow.h:662
> +    if (element() && element()->isRootEditableElement() && hasOverflowClip()
&& style().isLeftToRightDirection())
> +	   return caretWidth;

I think this should include the "!paddingEnd()" check too (see Comment #7).
-This also has an unfortunate side effect of having different renderer width
when some (non-geometry related) style changes. Let's see if it causes any
issues. We could always fall back to the simple, let's always add a padding
approach.