[webkit-reviews] review granted: [Bug 212714] Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder : [Attachment 401808] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Pinki Gyanchandani
<pgyanchandani at apple.com>'s request for review:
Bug 212714: Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=212714

Attachment 401808: Patch

https://bugs.webkit.org/attachment.cgi?id=401808&action=review




--- Comment #37 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 401808
  --> https://bugs.webkit.org/attachment.cgi?id=401808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401808&action=review

r=me

>>
LayoutTests/fast/rendering/widget-removal-in-render-tree-builder-crash.html:38
>> +<details id="z" open="true" ontoggle="runTest()">a</details>
> 
> I am still very skeptical of running test JS in the middle of parsing. Not
blocking review, but this could be worth some more effort.

Pinki, can you test whether this test still fails without your patch if you
move the call to runTest() into the window load event?