[webkit-reviews] review canceled: [Bug 212002] [GLIB] Add API to make JSCContext remotely inspectable : [Attachment 399606] RFC Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has canceled Adrian Perez <aperez at igalia.com>'s
request for review:
Bug 212002: [GLIB] Add API to make JSCContext remotely inspectable
https://bugs.webkit.org/show_bug.cgi?id=212002

Attachment 399606: RFC Patch

https://bugs.webkit.org/attachment.cgi?id=399606&action=review




--- Comment #4 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 399606
  --> https://bugs.webkit.org/attachment.cgi?id=399606
RFC Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399606&action=review

Clearing r? because this is a WIP.  Please set r? when it's not a WIP and feel
free to nag for feedback even if you don't set r?.

> Source/JavaScriptCore/API/glib/JSCContext.cpp:1126
> +    auto* globalObject = toJSGlobalObject(context->priv->jsContext.get());

This is one of those cases where auto doesn't help us.	It's not a super big
deal, but I thought I'd share my thinking here.  Lots of JSC code, include
things like this, is going to be read more times by more people than it is
written or modified, so you putting in the effort to write "JSGlobalObject*"
instead of "auto*" is a net win for the project.

I don't think that this is always true.  But I do think it's true for dealing
with sketchy JSC god objects like JSGlobalObject.