[webkit-reviews] review granted: [Bug 209518] [WebGL2] Uniform Buffer Objects : [Attachment 401813] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 209518: [WebGL2] Uniform Buffer Objects
https://bugs.webkit.org/show_bug.cgi?id=209518

Attachment 401813: Patch

https://bugs.webkit.org/attachment.cgi?id=401813&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 401813
  --> https://bugs.webkit.org/attachment.cgi?id=401813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401813&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1917
> +	   {

Our coding style puts the open brace on the same line as the case, and the
closing brace on a single line at the same indentation as the case. That way
the scoped code doesn't look doubly indented.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1995
> +    GLint r = 0;

Could we name this "result"?

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2003
> +    case GraphicsContextGL::UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
> +	   {

Same note here about indentation.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6274
> +	   synthesizeGLError(GraphicsContextGL::INVALID_VALUE, functionName,
"location length > max");

Suggest: location length is too large

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:1941
> +    // Use getActiveUniformBlockivRobustANGLE instead
> +    notImplemented();

Could you add:

RELEASE_LOG(WebGL, "Use getActiveUniformBlockivRobustANGLE instead.");