[webkit-reviews] review granted: [Bug 213155] [JSC] el(Greek) characters' upper-case conversion is locale-sensitive : [Attachment 401801] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213155: [JSC] el(Greek) characters' upper-case conversion is
locale-sensitive
https://bugs.webkit.org/show_bug.cgi?id=213155

Attachment 401801: Patch

https://bugs.webkit.org/attachment.cgi?id=401801&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 401801
  --> https://bugs.webkit.org/attachment.cgi?id=401801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401801&action=review

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1586
> +    const HashSet<String> availableLocales({ "az"_s, "el"_s , "lt"_s, "tr"_s
});

Seems that our implementation is far too literal. Making a HashSet here seems
so inefficient. And repeating this information here instead of getting it from
ICU also seems weak.

Anyway, not a comment about this patch, I suppose.