[webkit-reviews] review granted: [Bug 213139] Automation.computeElementLayout should return iframe-relative element rects (when coordinate system is 'Page') : [Attachment 401794] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 213139: Automation.computeElementLayout should return iframe-relative
element rects (when coordinate system is 'Page')
https://bugs.webkit.org/show_bug.cgi?id=213139

Attachment 401794: Patch

https://bugs.webkit.org/attachment.cgi?id=401794&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 401794
  --> https://bugs.webkit.org/attachment.cgi?id=401794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401794&action=review

r=me, nice fix :)

> Source/WebKit/ChangeLog:14
> +	   Covered by existing WPT test suite. The semantics of this command
are under review, as

I always hated "WPT test" ... it's so redundant ��

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:689
>      case CoordinateSystem::LayoutViewport:

NIT: we should wrap this `case` in `{` and `}` so
`elementBoundsInRootCoordinates` is local to just this `case` (i'd also be fine
if you inlined it)

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:747
> +	   auto inViewCenterPointInRootCoordinates =
convertPointFromFrameClientToRootView(frameView, elementInViewCenterPoint);

Ditto (:689)