[webkit-reviews] review granted: [Bug 213145] [iOS] Preferences are not being observed if the process pool is being created after activation : [Attachment 401778] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 213145: [iOS] Preferences are not being observed if the process pool is
being created after activation
https://bugs.webkit.org/show_bug.cgi?id=213145

Attachment 401778: Patch

https://bugs.webkit.org/attachment.cgi?id=401778&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 401778
  --> https://bugs.webkit.org/attachment.cgi?id=401778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401778&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:474
> +	       startObservingPreferenceChanges();

Do we need to do anything special to stop observing preferences in this case?
Or is it handled automatically by the normal code paths?