[webkit-reviews] review granted: [Bug 213118] Add a quirk to allow starting AudioContext if document was interacted : [Attachment 401715] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 213118: Add a quirk to allow starting AudioContext if document was
interacted
https://bugs.webkit.org/show_bug.cgi?id=213118

Attachment 401715: Patch

https://bugs.webkit.org/attachment.cgi?id=401715&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 401715
  --> https://bugs.webkit.org/attachment.cgi?id=401715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401715&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:1089
> +static bool isDocumentAllowingAutoplayWebAudio(const Document& document)

Minor nit: "is ... allowing" isn't quite right. Maybe something like
"documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"?