[webkit-reviews] review granted: [Bug 213124] In isolated tree mode 2, AXIsolatedObject::setChildrenIDs should be called only on secondary thread. : [Attachment 401727] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 213124: In isolated tree mode 2, AXIsolatedObject::setChildrenIDs should be
called only on secondary thread.
https://bugs.webkit.org/show_bug.cgi?id=213124

Attachment 401727: Patch

https://bugs.webkit.org/attachment.cgi?id=401727&action=review




--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 401727
  --> https://bugs.webkit.org/attachment.cgi?id=401727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401727&action=review

> Source/WebCore/ChangeLog:11
> +	   - The unsigned int range for object IDs was being overrun for large
number of objects like in the case of the sample page in
<rdar://problem/59331146>. INcreased the size of AXID to size_t.

INcreased -> Increased

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:75
> +typedef size_t AXID;

should we make this a uint64_t