[webkit-reviews] review granted: [Bug 213117] Change FileReader.error to DOMException from obsoleted FileError : [Attachment 401726] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 213117: Change FileReader.error to DOMException from obsoleted FileError
https://bugs.webkit.org/show_bug.cgi?id=213117

Attachment 401726: Patch

https://bugs.webkit.org/attachment.cgi?id=401726&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 401726
  --> https://bugs.webkit.org/attachment.cgi?id=401726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401726&action=review

r=me with changes.

> Source/WebCore/fileapi/FileReader.cpp:226
> +	   RefPtr<DOMException> exception =
DOMException::create(e.exception());

We don't need this local variable. This can be:
m_error = DOMException::create(e.exception());

> Source/WebCore/fileapi/FileReader.h:73
> +    RefPtr<DOMException> error() { return m_error; }

This should return a DOMException*, not need to ref:
DOMException* error() const { return m_error.get(); }

> Source/WebCore/fileapi/FileReader.idl:55
> +    readonly attribute DOMException error;

This should be:
readonly attribute DOMException? error;

As per spec, since it can return null.