[webkit-reviews] review granted: [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch : [Attachment 401722] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 213037: Stop to use ActiveDOMObject::setPendingActivity() for
WebCore/Modules/fetch
https://bugs.webkit.org/show_bug.cgi?id=213037

Attachment 401722: Patch

https://bugs.webkit.org/attachment.cgi?id=401722&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 401722
  --> https://bugs.webkit.org/attachment.cgi?id=401722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401722&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:-259
> -    setPendingActivity(*this);

We are no longer refing the FetchBodyOwner while loading the blo.
This is a potential behavioural change if we do not have a
JSFetchRequest/JSFetchResponse to keep the FetchBodyOwner alive.
Looking at the call sites, this should be fine.

> Source/WebCore/Modules/fetch/FetchBodyOwner.h:106
> +    bool virtualHasPendingActivity() const override;

Could probably be final.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:53
>      if (m_bodyOwner)

No need for this if check.