[webkit-reviews] review granted: [Bug 213111] [LFC][TFC] Add support for min/max-width : [Attachment 401705] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 213111: [LFC][TFC] Add support for min/max-width
https://bugs.webkit.org/show_bug.cgi?id=213111

Attachment 401705: Patch

https://bugs.webkit.org/attachment.cgi?id=401705&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 401705
  --> https://bugs.webkit.org/attachment.cgi?id=401705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401705&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:401
> +ContentWidthAndMargin BlockFormattingContext::computedWidthAndMargin(const
FloatingContext& floatingContext, const Box& layoutBox, const ConstraintsPair&
constraintsPair)

It is somewhat confusing to have both 'computeWidthAndMargin' and
'computedWidthAndMargin' functions.

Maybe this could be 'computeContentWidthAndMargin' based on the return type?