[webkit-reviews] review granted: [Bug 210739] [SOUP] Disable HSTS for requests when cookies will be blocked by ITP : [Attachment 401718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 06:50:35 PDT 2020


Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 210739: [SOUP] Disable HSTS for requests when cookies will be blocked by
ITP
https://bugs.webkit.org/show_bug.cgi?id=210739

Attachment 401718: Patch

https://bugs.webkit.org/attachment.cgi?id=401718&action=review




--- Comment #17 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 401718
  --> https://bugs.webkit.org/attachment.cgi?id=401718
Patch

I think this is correct.

The only trick here is that we want Upgrade Insecure Requests to take
precedence, so the request should still be upgraded to HTTPS if that's used
even if cookies are blocked. But that should be handled... somewhere else... so
it should be fine.


More information about the webkit-reviews mailing list