[webkit-reviews] review granted: [Bug 194749] Relative font size values (em) within CSS animations compound : [Attachment 401721] patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 194749: Relative font size values (em) within CSS animations compound
https://bugs.webkit.org/show_bug.cgi?id=194749

Attachment 401721: patch

https://bugs.webkit.org/attachment.cgi?id=401721&action=review




--- Comment #13 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 401721
  --> https://bugs.webkit.org/attachment.cgi?id=401721
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401721&action=review

> LayoutTests/animations/keyframe-em-unit.html:5
> +div {
> +  font-size: 2em;
> +  animation: div 3s infinite alternate;
> +}

You can make the duration any value and add `freeze` to ensure the animated
style will override the base style. You can remove `alternate` for sure.

> Source/WebCore/style/StyleTreeResolver.cpp:324
> +		   // FIXME: Remove this hack and pass the parent style via
updateCSSAnimationsForElement.

Can you file a bug and assign it to me to do this refactor?