[webkit-reviews] review granted: [Bug 210276] [GTK4] Get MiniBrowser ready for GTK4 : [Attachment 401632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 01:10:38 PDT 2020


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 210276: [GTK4] Get MiniBrowser ready for GTK4
https://bugs.webkit.org/show_bug.cgi?id=210276

Attachment 401632: Patch

https://bugs.webkit.org/attachment.cgi?id=401632&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 401632
  --> https://bugs.webkit.org/attachment.cgi?id=401632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401632&action=review

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:74
> +    action =
g_action_map_lookup_action(G_ACTION_MAP(searchBox->actionGroup),
"beginnig-word");

Typo: beginnig → beginning.

I saw this in one of the dependant patches, so if you fix it on the other
patch first I suppose when you rebase this one you'll get it fixed, too :)

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:131
> +    gtk_editable_set_text(GTK_EDITABLE(searchBox->entry), "");

I was about to mention this could be in “GtkVersioning.h”, but of
course we only want to use public headers in the MiniBrowser ��️

Maybe it would be neat to have such a header for the MiniBrowser?
My feeling is that it would simplify quite a lot the #if-#endif
churn in many places along this patch.


More information about the webkit-reviews mailing list