[webkit-reviews] review granted: [Bug 213104] Document.currentScript does not work for SVGScriptElements : [Attachment 401702] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 20:42:10 PDT 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 213104: Document.currentScript does not work for SVGScriptElements
https://bugs.webkit.org/show_bug.cgi?id=213104

Attachment 401702: Patch

https://bugs.webkit.org/attachment.cgi?id=401702&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 401702
  --> https://bugs.webkit.org/attachment.cgi?id=401702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401702&action=review

r=me

>
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:19
13
> +	   return NULL;

nullptr?

> Source/WebKitLegacy/mac/DOM/DOMDocument.mm:409
> +	   return NULL;

nil?


More information about the webkit-reviews mailing list