[webkit-reviews] review granted: [Bug 213093] [IPC] Add WTF::EnumTraits<> for every enum type used in IPC : [Attachment 401682] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 11 15:42:13 PDT 2020
Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 213093: [IPC] Add WTF::EnumTraits<> for every enum type used in IPC
https://bugs.webkit.org/show_bug.cgi?id=213093
Attachment 401682: Patch v1
https://bugs.webkit.org/attachment.cgi?id=401682&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 401682
--> https://bugs.webkit.org/attachment.cgi?id=401682
Patch v1
Super irritating how every enum has to be listed out twice. We have got to find
a better idiom for this. Seems like the failure mode when you forget to include
one of the values is also non-obvious, especially if it’s a value that’s only
occasionally sent cross-process.
More information about the webkit-reviews
mailing list