[webkit-reviews] review granted: [Bug 213069] [JSC] Return DisposableCallSiteIndex when destroying GCAwareJITStubRoutineWithExceptionHandler : [Attachment 401624] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213069: [JSC] Return DisposableCallSiteIndex when destroying
GCAwareJITStubRoutineWithExceptionHandler
https://bugs.webkit.org/show_bug.cgi?id=213069

Attachment 401624: Patch

https://bugs.webkit.org/attachment.cgi?id=401624&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 401624
  --> https://bugs.webkit.org/attachment.cgi?id=401624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401624&action=review

r=me

>>> Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:132
>>> +	 m_codeOriginPool = nullptr;
>> 
>> When is this function called?
> 
> This function is called when CodeBlock is destroying whole JIT related data.
> 
> 1. CodeBlock itself is getting destroyed.
> 2. Destroying entire JITData via resetJITData
> 
> So, we can just make it nullptr, since everything will be destroyed.

Right. That's what I remembered, just wanted to make sure.