[webkit-reviews] review denied: [Bug 213038] WebKit: Make UIGestureRecognizer build for watchOS and tvOS : [Attachment 401643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 10:47:40 PDT 2020

Tim Horton <thorton at apple.com> has denied Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 213038: WebKit: Make UIGestureRecognizer build for watchOS and tvOS

Attachment 401643: Patch


--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401643
  --> https://bugs.webkit.org/attachment.cgi?id=401643

View in context: https://bugs.webkit.org/attachment.cgi?id=401643&action=review

> Source/WTF/wtf/PlatformHave.h:450

As previously mentioned, a IOS_FAMILY + IPHONE_OS_VERSION* check is always

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:422
> -#if PLATFORM(IOS) && !defined(__IPHONE_13_4)

This used defined(__IPHONE_13_4) instead of MIN_REQUIRED for a reason! Blame it
and see.

More information about the webkit-reviews mailing list