[webkit-reviews] review denied: [Bug 213038] WebKit: Make UIGestureRecognizer build for watchOS and tvOS : [Attachment 401643] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 213038: WebKit: Make UIGestureRecognizer build for watchOS and tvOS
https://bugs.webkit.org/show_bug.cgi?id=213038

Attachment 401643: Patch

https://bugs.webkit.org/attachment.cgi?id=401643&action=review




--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401643
  --> https://bugs.webkit.org/attachment.cgi?id=401643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401643&action=review

> Source/WTF/wtf/PlatformHave.h:450
> +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400)

As previously mentioned, a IOS_FAMILY + IPHONE_OS_VERSION* check is always
wrong.

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:422
> -#if PLATFORM(IOS) && !defined(__IPHONE_13_4)
> +#if !HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS)

This used defined(__IPHONE_13_4) instead of MIN_REQUIRED for a reason! Blame it
and see.