[webkit-reviews] review granted: [Bug 212898] [GTK] MiniBrowser: stop using GtkToolbar : [Attachment 401332] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 212898: [GTK] MiniBrowser: stop using GtkToolbar
https://bugs.webkit.org/show_bug.cgi?id=212898

Attachment 401332: Patch

https://bugs.webkit.org/attachment.cgi?id=401332&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 401332
  --> https://bugs.webkit.org/attachment.cgi?id=401332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:473
> +    return webkit_web_view_get_zoom_level(webView) != 1.0;

Comparing floating point numbers is usually a bad idea, due to rounding errors
and whatnot. Probably not much of an issue here, but the safest would be
rounding
to the nearest integer and comparing that:

  return lrint(webkit_web_view_get_zoom_level(webView)) == 1;

No strong opinion, though. Feel free to leave the code as-is if you prefer.