[webkit-reviews] review granted: [Bug 212817] [GTK] MiniBrowser: stop using GtkToolbar for the search bar : [Attachment 401144] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 11 07:15:10 PDT 2020
Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 212817: [GTK] MiniBrowser: stop using GtkToolbar for the search bar
https://bugs.webkit.org/show_bug.cgi?id=212817
Attachment 401144: Patch
https://bugs.webkit.org/attachment.cgi?id=401144&action=review
--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 401144
--> https://bugs.webkit.org/attachment.cgi?id=401144
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401144&action=review
LGTM, but please fix the typos before landing :)
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:71
> + action = g_action_map_lookup_action(G_ACTION_MAP(actionGroup),
"beginnig-word");
Typo: beginnig → beginning.
(The same type is around in a few places more, I won't point out every
instance.)
More information about the webkit-reviews
mailing list