[webkit-reviews] review granted: [Bug 213028] [css-grid] Reimport WPT tests removed in r262809 : [Attachment 401594] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 213028: [css-grid] Reimport WPT tests removed in r262809
https://bugs.webkit.org/show_bug.cgi?id=213028

Attachment 401594: Patch

https://bugs.webkit.org/attachment.cgi?id=401594&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 401594
  --> https://bugs.webkit.org/attachment.cgi?id=401594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401594&action=review

r=me, but please review the comment and change the expectations for that test
accordingly.

> LayoutTests/TestExpectations:1059
> +webkit.org/b/209461
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-c
ontribution-001.html [ Failure ]

I think the usual way to import testharness tests is to have a -expected.txt
file with several FAIL messages, instead of marking them as Failure in the
TestExpectations file. As that way we'd realize when there's any single change
regarding that test, while the other way around we'll only realize when the
whole test starts to PASS.