[webkit-reviews] review granted: [Bug 213061] [iOS] editing/pasteboard/dom-paste tests consistently time out : [Attachment 401608] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 10 17:42:59 PDT 2020


Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 213061: [iOS] editing/pasteboard/dom-paste tests consistently time out
https://bugs.webkit.org/show_bug.cgi?id=213061

Attachment 401608: Patch

https://bugs.webkit.org/attachment.cgi?id=401608&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 401608
  --> https://bugs.webkit.org/attachment.cgi?id=401608
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401608&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4252
> +	   completionHandler([WKAutocorrectionContext
autocorrectionContextWithWebContext:_lastAutocorrectionContext]);

Is it ever OK to do this twice? If not, then can we std::exchange to clear out
_lastAutocorrectionContext here?


More information about the webkit-reviews mailing list