[webkit-reviews] review granted: [Bug 213057] Text manipulation does not observe inserted elements that are invisible : [Attachment 401600] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 213057: Text manipulation does not observe inserted elements that are
invisible
https://bugs.webkit.org/show_bug.cgi?id=213057

Attachment 401600: Patch

https://bugs.webkit.org/attachment.cgi?id=401600&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 401600
  --> https://bugs.webkit.org/attachment.cgi?id=401600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401600&action=review

> Source/WebCore/ChangeLog:10
> +	   element. It currently sets the observing range to be the visible
start postion and visible end position of the 

postion => position

> Source/WebCore/ChangeLog:15
> +	   Test: TextManipulation.CompleteTextManipulationCanSplitContent

Nit - TextManipulation.StartTextManipulationFindsInsertedClippedText