[webkit-reviews] review granted: [Bug 213046] Improve url-setters.html WPT test : [Attachment 401575] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 213046: Improve url-setters.html WPT test
https://bugs.webkit.org/show_bug.cgi?id=213046

Attachment 401575: Patch

https://bugs.webkit.org/attachment.cgi?id=401575&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 401575
  --> https://bugs.webkit.org/attachment.cgi?id=401575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401575&action=review

> Source/WebCore/html/URLDecomposition.cpp:128
> +    if (fullURL.isValid())
> +	   setFullURL(fullURL);

Can we put this check inside the setFullURL function? Does something fail if we
do that?