[webkit-reviews] review granted: [Bug 213043] Unify some of RunLoop and callOnMainThread : [Attachment 401572] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 10 13:35:33 PDT 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 213043: Unify some of RunLoop and callOnMainThread
https://bugs.webkit.org/show_bug.cgi?id=213043
Attachment 401572: Patch
https://bugs.webkit.org/attachment.cgi?id=401572&action=review
--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 401572
--> https://bugs.webkit.org/attachment.cgi?id=401572
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401572&action=review
>>> Source/WTF/wtf/cocoa/MainThreadCocoa.mm:107
>>> + });
>>
>> Since this is just calling a function can we write this instead?
>>
>> RunLoop::web().dispatch(WTF::dispatchFunctionsFromMainThread);
>>
>> I suspect it might be slightly more efficient as well.
>
> This seems wrong? The function is supposed to dispatch on the main thread.
Never mind, confused by the confusion of the past.
>>> Source/WTF/wtf/cocoa/MainThreadCocoa.mm:119
>>> + });
>>
>> Ditto.
>
> This also seems wrong.
Never mind, confused by the confusion of the past.
More information about the webkit-reviews
mailing list