[webkit-reviews] review granted: [Bug 208232] WebDriver on non-iOS ports cannot perform ActionChain which has scrolling down to the element and click it : [Attachment 401569] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 10 13:02:50 PDT 2020
Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 208232: WebDriver on non-iOS ports cannot perform ActionChain which has
scrolling down to the element and click it
https://bugs.webkit.org/show_bug.cgi?id=208232
Attachment 401569: Patch
https://bugs.webkit.org/attachment.cgi?id=401569&action=review
--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 401569
--> https://bugs.webkit.org/attachment.cgi?id=401569
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401569&action=review
r=me
> Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:140
> + IntPoint locationInView = WebCore::IntPoint(locationInViewport.x(),
locationInViewport.y() + page.topContentInset());
Do we want to do this in a caller function?
Aside: this code makes me wish there was a `IntPoint IntPoint::move(int dx, int
dy);` that does this :(
More information about the webkit-reviews
mailing list